Hi, when I attach a screenshot with the chrome extension, it looks like it takes only what I can see on the window. But I think before (until last week), it took the whole page. Is it just me?
I see the same thing, though I don't recall what it was before. Looking at the code, it seems the intention is to do a full capture if the page is text/html, and only a "visible capture" otherwise. But it doesn't appear to work that way, as only the visible content is captured even for HTML. https://github.com/dust-tt/dust/blob/422d0ec2167c638aea4dcb048f5da634f97805e9/extension/platforms/chrome/background.ts#L274-L317
Thanks for flagging Tifany Clemenceau! I confirm that the expected behavior is to have it take a screenshot of the full page. I'll share the bug with the team 😊
Adding Thomas Draier (Dust) as I was just chatting with him about that. Though in my case, playing with it some more, I commonly run into a cases where the screenshot logic fails with Cannot get page content. Failed to get a screenshot of the page.
I've just tried and it seems to work as before for me - it scrolls and takes the whole page in one or multiple files. David Ebbo can you send me your html file so that i can test on it ?
It's quite trivial: https://gist.github.com/davidebbo/8a075cbfb14cb148984834cb38567d48. Works for me full screen, but fails when I reduce my window.
for .txt file it does not scroll at all, but if i use it with .html it works well - in all cases I don't see the error you got
can you right click in extension / inspect , try again, and show me what you have in the console when you get the error ?
background.js:292 Unknown message: [object Object].
(anonymous) @ background.js:292
Unchecked runtime.lastError: This request exceeds the MAX_CAPTURE_VISIBLE_TAB_CALLS_PER_SECOND quota.
background.js:292 Empty captures array
(anonymous) @ background.js:292
background.js:292 Error getting active tab content: Error: Failed to get a screenshot of the page.
at background.js:292:859630
(anonymous) @ background.js:292
background.js:292 Unknown message: [object Object].
This has some context: https://issues.chromium.org/issues/40764505. Seems there is a quota of screenshot per second. But then it' s puzzling that it doesn't affect everyone. BTW, I didn't mean to hijack Tifany Clemenceau’s issue, since she's seeing something different.
seems a matter of config (although I don't see how to easily change it) - weird that we don't have the same values. But yes orginal issues from Tifany Clemenceau looks different - capturing the whole page only works for html documents, and maybe not on all (depending on the structure of the document)
I'll open a GitHub issue for my issue. And it is not by at all urgent if I appear to be the only one seeing it...
Ok, let's use https://github.com/dust-tt/dust/issues/11991 for my issue, and focus on Tifany's issue here. Tifany Clemenceau could you link to a specific page where you see this? Thanks.
hey, on this page, it starts to scroll down and at the middle, this error appears:
I tried on linkedin, it’s working well
so I guess it depends on the page then
That page has wild scrolling behavior, where as you go down, sometimes only the left side scrolls, and sometimes only the right. I'll let Thomas Draier (Dust), but I'm guessing it's just too complex for the algorithm that tries to patch things together in chunks.
The scrolling is supported here, but the page is too long - so it depends on the height of your browser window (for me it works when I have full height, but sends an error when i reduce the size). We definitely need to improve the error message to make it clearer
How can I change the height?
It means if the screenshot doesn’t work, I can have a workaround changing the height? (at least I can give it a try)
Make the window as big as possible, and then zoom out a bunch, making the text really small.